Skip to content

fix(website): link to external constructors #10869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

Qjuh
Copy link
Member

@Qjuh Qjuh commented Apr 29, 2025

Please describe the changes this PR makes and why it should be merged:

Mark constructors as external too on external classes to fix their source code link

example: https://discord.js.org/docs/packages/discord.js/14.19.2/ContainerBuilder:Class#constructor

Status and versioning classification:

@Qjuh Qjuh requested review from a team as code owners April 29, 2025 22:03
@Qjuh Qjuh requested a review from Jiralite April 29, 2025 22:03
Copy link

vercel bot commented Apr 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 5, 2025 7:07am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 5, 2025 7:07am

Copy link

vercel bot commented Apr 29, 2025

@Qjuh is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.58%. Comparing base (bae1b4c) to head (b524e22).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10869   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files         262      262           
  Lines       16136    16134    -2     
  Branches     1547     1549    +2     
=======================================
  Hits         6871     6871           
+ Misses       9253     9251    -2     
  Partials       12       12           
Flag Coverage Δ
brokers 31.41% <ø> (ø)
builders 80.49% <ø> (ø)
collection 100.00% <ø> (ø)
core 0.89% <ø> (ø)
formatters 99.63% <ø> (ø)
proxy 65.88% <ø> (ø)
rest 87.76% <ø> (ø)
util 43.28% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 70.90% <ø> (ø)
ws 36.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js May 5, 2025
@kodiakhq kodiakhq bot merged commit 6efdf3b into discordjs:main May 5, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js May 5, 2025
@Qjuh Qjuh deleted the website/external-constructor branch May 14, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants